sanyaade-g2g-repos / grafx2

Automatically exported from code.google.com/p/grafx2
0 stars 0 forks source link

Color index 255 selected as FG by deafult #490

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Start grafx2
2. Last colour index (255) selected by default
3. When you dismiss the splash screen this will send you to the end of the 
palette

Ideally if deafult bg index is 0, then default fg index could be 1.
Unless you have such a palette setup that shows all 256 colours, you would get 
thrown to the end of the palette and away from your colours.

A VERY minor nag, but it's bothered me slightly for so long, I had to report it 
:)

Original issue reported on code.google.com by ilija.melentijevic on 31 May 2012 at 1:35

GoogleCodeExporter commented 9 years ago
It depends on the skin's palette (which serves as the default palette) : grafx2 
automatically selects the whitest color as FG, and scrolls the palette area to 
ensure that color is in the visible part. Do you have an idea for improvement ?

Original comment by yrizoud on 31 May 2012 at 8:05

GoogleCodeExporter commented 9 years ago
What I'd do is :
 * Scroll the palette all the way to left/top
 * Pick the brightest color from the visible ones

Original comment by pulkoma...@gmail.com on 10 Jun 2012 at 8:10

GoogleCodeExporter commented 9 years ago
Implemented in r2021.
Brightest and darkest colors from the visible palette (columns x rows) are 
selected on startup.
If you load a file from command line, BG is selected as the transparent color 
if the image has transparent BG, otherwise blackest from visible colors. Then 
FG is selected as brightest or darkest of the visible colors, depending if the 
selected BG was dark of light.

Original comment by yrizoud on 30 Sep 2012 at 4:30