Contour fill

[GoogleCodeExporter]

Ability to change zoom level (when zoomed in) via keyboard shortcuts.
I suggest ctrl+ and ctrl- :D

(great program, btw! feel free to browse my work at
http://www.pixeljoint.com/p/9270.htm)

Original issue reported on code.google.com by ilija.melentijevic on 30 Jan 2009 at 11:55

[GoogleCodeExporter]

Thanks for testing our program iLKke :)
Default shortcuts for zoom in/out are Keypad+ and Keypad-, but you can use 
gfxcfg to
change this.

Original comment by yrizoud on 31 Jan 2009 at 1:33

• Removed labels: OpSys-

[GoogleCodeExporter]

Please read the documentation before reporting bugs :)
Marking this as invalid ...

Thanks for the report, for using the program and for adding yourself to the 
user 
counter, anyways :)

Original comment by pulkoma...@gmail.com on 31 Jan 2009 at 12:31

• Changed state: Invalid

[GoogleCodeExporter]

Yay! Implemented even before I requested it! \o/
Seriously, sorry for not being more careful there :P

Original comment by ilija.melentijevic on 31 Jan 2009 at 12:38

[GoogleCodeExporter]

It's no problem, keep these suggestions coming, I'll sort them out.
I have huge respect for your work, and I feel honored if Grafx2 can be useful. 

Original comment by yrizoud on 31 Jan 2009 at 2:25

[GoogleCodeExporter]

Is it okay for me to post a list of ideas here, so you can sort it out, or 
should I
post a list as a new issue (and then have you sort it out)?

Original comment by ilija.melentijevic on 31 Jan 2009 at 4:32

[GoogleCodeExporter]

You can use this Issue and I'll answer and split things as needed, or use p-m on
pixeljoint, or mail us (pulkomandy and yrizoud at gmail.com), as you prefer.

Original comment by yrizoud on 31 Jan 2009 at 5:51

• Changed title: iLKke ideas

[GoogleCodeExporter]

OK then!

These are just off the top of my head. As I dive deeper into the program I may 
have
some more ideas. It is possible that some of these features are already 
present, but
I think not.

1. Contour Fill
A feature in pretty much all Amiga programs since DPaint. It is one of the 
freehand
modes that works like a continuous freehand but when you release the mouse 
button, it
connects the start and end point and fills the contour you drew. It has a 
somewhat
unique behavior when you intersect your contour. Please see attached image for
example. This tool is useful for laying out an image in standard paint mode. In 
shade
mode or with transparency, you can pretty much make the whole image with it. In 
fact
that was how I did all my pixels before moving on to PC, cause NONE of the PC
programs have that tool (only that old dpaint version for dos).

2. Shade mode with Continuous Freehand, Transparency with Continuous Freehand
Because of the way shade and transparency work, and because of the way 
continuous
freehand works, they are pretty much useless when used together as brushes stack
rapidly one over another and all intermediate steps are lost, even when moving 
the
mouse really fast. I don't know how hard it is to make, but I'd propose a 
special
kind of behavior for shade and transp when used with C.F. In it, transparency or
shade is performed on the stroke as a whole. Imagine that you picked the whole 
stroke
as a brush and then clicked once with it with shade or transp on. This would 
make it
much more useful, but consider this a low-priority if you plan on implementing
contour fill :D

3. Distinct border with small images
As far as I was able to tell, the border around the image (when image is 
smaller than
screen size) is always black, and is denoted by a dotted line. It would be 
useful to
be able to change the border color and to scroll the image on the screen (so 
it's not
always in the top left corner). Brilliance didn't have the customizable border 
color
but it used a pattern combining black and another non-black color to make sure 
that
the border is always clearly different from the image itself.

I will now test the program thoroughly to see what's already in there and how 
it behaves.

Original comment by ilija.melentijevic on 31 Jan 2009 at 7:48

Attachments:

• [contour fill.gif](https://storage.googleapis.com/google-code-attachments/grafx2/issue-90/comment-7/contour fill.gif)

[GoogleCodeExporter]

1. Contour fill is there, as "Filled Polyform" (Ctrl+Shift+N), with a variant:
release the mouse button to draw line segment. To end the form, click the other 
mouse
button. Note that the same mechanism also allows brush grabbing, it's the Lasso 
(Ctrl+B)

2. In this case you use "Feedback off" in the FX window, and it will behave 
exactly
how you described. The ability to turn feedback on and off, multiplied by all 
tools
and effects, it gives a lot of combinations :)

3. The dotted line can be toggled off (Settings: "Limits:no"), but yeah, that's 
the
only thing you can do currently. The background area is hard-coded to be black 
(or
darkest palette color), and also the viewport cannot be moved, it starts in 
top-left.

Original comment by yrizoud on 31 Jan 2009 at 8:05

[GoogleCodeExporter]

Oh, cool! 
The extra click with Filled Polyform does hinder the workflow a bit. I will 
test it
more to see how it fits. It's still much better than not having the tool at all 
:D

On another note, is it at all possible that the graphics for the icon and 
perhaps
even the logo be in an external image file, so it can be customized/edited?

Original comment by ilija.melentijevic on 31 Jan 2009 at 8:48

[GoogleCodeExporter]

I can make the button work this way:
Left click: activate function
Right click: toggle function between:
- Filled polygon
- Filled polyform
- Contour fill (new)

Check out gfx2gui.gif in the program's directory. Note that the whole program is
256-color, so the splash screen can only be shown at startup if no image is 
loaded.
All other graphics are 4-color and dynamically remapped according to current 
palette.

Original comment by yrizoud on 31 Jan 2009 at 9:29

[GoogleCodeExporter]

That would be great! Also I noticed that this icon always stays the same, thus 
not
indicating which tool is currently on. That's a minor issue (you can always 
test to
see which tool is on) but the rest of the GUI is pretty clear in this regard.

I swear I don't see gfx2gui.gif in my folder. Only gifs I have are the two 
icons.

Original comment by ilija.melentijevic on 31 Jan 2009 at 9:47

[GoogleCodeExporter]

Ah sorry, I did it after the 98.0% stable version, so it's only in the svn, 
which is
not totally stable at the moment (keyboard issues)
To give you an idea, the skin file is at
http://grafx2.googlecode.com/svn/trunk/gfx2gui.gif (click 'view raw file')

As for icons, I am drawing the ones for filled polyform / contour fill, and I 
don't
quite know how to show the difference...

Original comment by yrizoud on 31 Jan 2009 at 10:12

[GoogleCodeExporter]

Well, it's not really that important as long as the icons are different, I 
think.
By the way, I've invited you to google talk, if you don't use it, we can still 
chat
from inside gmail.

Original comment by ilija.melentijevic on 31 Jan 2009 at 10:17

[GoogleCodeExporter]

Original comment by pulkoma...@gmail.com on 1 Feb 2009 at 1:49

• Changed state: Accepted
• Added labels: OpSys-All, Type-Enhancement
• Removed labels: Type-Defect

[GoogleCodeExporter]

(using this issue for contour fill, will open separate ones for the others)

Contour fill: New drawing tool, very similar to the existing Filled Polyform, 
but in
single click. It's familiar to many DP users, which justifies having a specific 
tool
for it.
iLKke has already provided an icon. It will be the 4th drawing mode of the 
freehand
drawing tool, because it's a better place than all the alternatives we could 
think,
and it doesn't cause extra modifications.

Original comment by yrizoud on 1 Feb 2009 at 7:19

• Changed title: Contour fill

[GoogleCodeExporter]

Done in r582.
Note that it ignores the current brush, and it's pixel-perfect, it fills the 
area +
the pixels that were shown in XOR color when you passed on them.

Original comment by yrizoud on 2 Feb 2009 at 1:01

• Changed state: Fixed

[GoogleCodeExporter]

Works like a dream! Please check your mail for some elaborate comments.

Original comment by ilija.melentijevic on 2 Feb 2009 at 7:34

[GoogleCodeExporter]

Todo: allow drawing single pixel.
Currently, clicking and releasing (without moving) cancels all

Original comment by yrizoud on 3 Feb 2009 at 12:11

• Changed state: Accepted

[GoogleCodeExporter]

Done in r586. 
But I noticed a missing refresh on the starting pixel, on this and all
polygons/lines, when using extreme zoom levels.

Original comment by yrizoud on 3 Feb 2009 at 1:22

• Changed state: Started

[GoogleCodeExporter]

Original comment by pulkoma...@gmail.com on 5 Feb 2009 at 8:39

• Added labels: Milestone-2.0

[GoogleCodeExporter]

The refresh is fixed in r659...I think. It was not visible with all cursors.
Nothing remaining about Contour fill tool.

Original comment by yrizoud on 26 Feb 2009 at 1:36

• Changed state: Fixed