Sync doesn't warn user when Syncing is not enabled

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Go to ListFinds
2. Select 'Sync' menu item
3.

What is the expected output? What do you see instead?

The finds should sync to server. But they won't if Syncing is not on in the 
Accounts/Sync settings.

Preferred fix:  Disable the Sync menu item unless Syncing is enabled.

Please use labels and text to provide additional information.

Original issue reported on code.google.com by ram8...@gmail.com on 20 Oct 2011 at 3:39

[GoogleCodeExporter]

One concern I would have about simply removing the Sync button when Sync is 
disabled is that this provides no information to the user about why that 
feature is unavailable, especially when the solution to the problem is not 
completely obvious.

Alternatively, Sync can actually be enabled by the application itself without 
any user intervention using this line:
ContentResolver.setSyncAutomatically(account, AUTHORITY, true);

This would, however, take away the user's ability to disable synchronization if 
they so desire.

Original comment by exciting...@gmail.com on 25 Oct 2011 at 1:45

[GoogleCodeExporter]

Another alternative would be to return a toast describing why the sync button 
is not usable. 

This provides feedback to the user while still allowing the user to have 
control over the app. 

Original comment by stan.f...@gmail.com on 25 Oct 2011 at 5:21

[GoogleCodeExporter]

If the menu item is disabled, you won't be able to generate a Toast from it.  
If we think it will be confusing for the user to have the menu item disabled, 
then we can leave it enabled and generate a Toast that Syncing is "Off" and 
needs to be set on in Settings. 

Original comment by ram8...@gmail.com on 25 Oct 2011 at 2:04

[GoogleCodeExporter]

Ok. So we go with the enabled Sync menu item and the Toast. 

Original comment by ram8...@gmail.com on 25 Oct 2011 at 3:42

• Changed state: Started

[GoogleCodeExporter]

Not sure how I missed the getSyncAutomatically() function last time I was 
looking for it.

Added a toast for when sync is disabled. Sync request is not aborted when this 
happens, so sync will be carried out if/when the user enables sync.

Original comment by exciting...@gmail.com on 29 Oct 2011 at 7:14

Attachments:

• issue240.patch

[GoogleCodeExporter]

Alas.  Before I could get to this patch, I fixed this issue with very similar 
code.

Original comment by ram8...@gmail.com on 7 Nov 2011 at 5:56

[GoogleCodeExporter]

I believe this issue has been resolved. 

Original comment by ram8...@gmail.com on 25 Nov 2011 at 10:47

• Changed state: Fixed