sanyaade-g2g-repos / posit-mobile

Automatically exported from code.google.com/p/posit-mobile
GNU Lesser General Public License v2.1
0 stars 0 forks source link

All plugins using ListMenu extension point have Map icon #262

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Run POSITx using a plugin using the ListMenu extension point (e.g. Log Finds)
2. Go to view finds and bring up the menu

What is the expected output? What do you see instead?
The plugin should have the icon it specified in plugins_preferences.xml. 
Instead it has the Map icon.

Original issue reported on code.google.com by exciting...@gmail.com on 13 Nov 2011 at 12:21

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
Actually this happens with the MainMenu extension point too. It's just that for 
the only MainMenu extension we have that's the right icon.

Original comment by exciting...@gmail.com on 13 Nov 2011 at 12:40

GoogleCodeExporter commented 9 years ago
I submitted a fix for this.  The code now pulls the name of the drawable from 
the Plugin object.  And then looks up its resource id when the menu is created. 
 This works for ListFinds menu, but not for PositMain, although the code is the 
same in both cases. 

Original comment by ram8...@gmail.com on 15 Nov 2011 at 3:36

GoogleCodeExporter commented 9 years ago
This issue was closed by revision 63d1aa0ed3de.

Original comment by ram8...@gmail.com on 15 Nov 2011 at 10:36

GoogleCodeExporter commented 9 years ago
Revision 63dlaa... fixes  issue #262.  The key was to copy the drawable from 
Android.jar in the Google APIs folder.  The actual drawable that worked best 
was res/drawable-mdpi/ic_menu_mapmode.png.   This is a medium density icon.   
When you used @android:drawable  in a layout XML, Android scales the icon to 
match the phone's display.

Original comment by ram8...@gmail.com on 15 Nov 2011 at 10:37