sanyaade-g2g-repos / posit-mobile

Automatically exported from code.google.com/p/posit-mobile
GNU Lesser General Public License v2.1
0 stars 0 forks source link

In Settings - SMS preferences has no check for valid phone number #297

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1.Go into settings
2.Click on default phone # under SMS preferences
3.Enter something random
4.Click OK

What is the expected output? What do you see instead?
Reject anything that doesn't look like a phone number. 

It should also provide a hint (default gray text that goes away upon clicking 
the text box) to show a valid phone format.

Please use labels and text to provide additional information.

Original issue reported on code.google.com by gordonle...@gmail.com on 11 Dec 2011 at 1:01

GoogleCodeExporter commented 9 years ago
Right, I'd forgotten about that. I'll fix this in a bit.

Original comment by exciting...@gmail.com on 13 Dec 2011 at 7:32

GoogleCodeExporter commented 9 years ago

Original comment by exciting...@gmail.com on 13 Dec 2011 at 7:32

GoogleCodeExporter commented 9 years ago
I've since changed the preference to the "phone" input type in one of my 
patches. (See issue 278.) I don't know if it actually checks if the phone 
number is valid, but if it is invalid, it will alert you when you try to send 
something.

I didn't put in the hint for the phone # format because phone numbers can be in 
a lot of different formats and it seems to accept just about any one of them. 

Original comment by exciting...@gmail.com on 15 Dec 2011 at 3:55

GoogleCodeExporter commented 9 years ago
Confirmed this is an issue.

Original comment by sonic...@gmail.com on 7 Apr 2014 at 6:35