sanyaade-g2g-repos / posit-mobile

Automatically exported from code.google.com/p/posit-mobile
GNU Lesser General Public License v2.1
0 stars 0 forks source link

To-Do Reminder Function Plug-in Infrastructure Enhancements #306

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
In order to make function plug-in's more (if not completely) independent of the 
core POSIT, explicit references to any specific function plug-in's should be 
remove from the core POSIT code.

For example, in "FindActivity.java", methods "onMenuItemSelected()", 
"onActivityResult()", and "displayContentInView()" all either explicitly 
mention "To-Do Reminder" plug-in or has code that set things for "To-Do 
Reminder" plug-in.

The above references should be removed completely to keep function plug-in 's 
separate entities from the core POSIT.

One possible solution to this is to move the above plug-in specific code into 
the actual plug-in itself as generic methods and have these generic  methods 
invoked in the core POSIT.

For example, "onActivityResult()" has plug-in specific code to add an alarm 
clock to the "Add Find" interface. We can instead move this code to the "To-Do 
Reminder" function plug-in as a generic method; and call this method through 
"functionPlugin.method()" in "onActivityResult()". This way, no explicit 
mention of any function plug-in is made.

Original issue reported on code.google.com by jiaxian....@gmail.com on 13 Dec 2011 at 7:18

GoogleCodeExporter commented 9 years ago
Hello all,

I am a student at Cal Poly Pomona working on an open source excursion project. 
Someone reading this may know my partner for this project, Aileen. She has 
recently submitted her bug patch for bug 306 to the Posit team and had it 
accepted. I am now looking for a bug/enhancement to work on as well. Originally 
I was going to work on a Mozilla bug, but it turned out that my bug fix was too 
much of an easy fix and was not deemed sufficient by my professor. I would like 
to work on this enhancement instead if that is alright.

Original comment by ttel...@csupomona.edu on 26 Apr 2012 at 10:50

GoogleCodeExporter commented 9 years ago
Assigning this to Tara.

Original comment by ram8...@gmail.com on 2 May 2012 at 10:46

GoogleCodeExporter commented 9 years ago
I'm looking at the "onActivityResult()" code in "FindActivity.java" and cannot 
see any references to any specific plug-ins. Has this been partially fixed 
already? Or is this just way over my head?

Original comment by ttel...@csupomona.edu on 3 May 2012 at 1:44

GoogleCodeExporter commented 9 years ago
Hi Tara,

You called it. It looks like this issue has been resolved.  You can see that 
the commented-out code just after onActivityResult() removes the dependency for 
the "Capture Media" plugin.  So it looks like this issue has been resolved. 

Why don't you clean up FindActivity  -- remove commented-out code and add 
descriptive comments to the methods that use callbacks -- and submit those 
changes as a patch for now.   Then we can look for another issue. 

-- ralph

Original comment by ram8...@gmail.com on 4 May 2012 at 3:01