sanyaade-g2g-repos / posit-mobile

Automatically exported from code.google.com/p/posit-mobile
GNU Lesser General Public License v2.1
0 stars 0 forks source link

Captured Media persists across Add & Edit Finds #328

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Create a find and capture media for it
2. Any find created afterwards will contain the same media on creation.

What is the expected output? What do you see instead?
Captured media should not be present for newly created finds.

Please use labels and text to provide additional information.

Original issue reported on code.google.com by and.mats...@gmail.com on 21 Jan 2012 at 11:31

GoogleCodeExporter commented 9 years ago
The same issue of persisting captured media exists when editing an existing 
Find.

*What steps will reproduce the problem?*
1. Create a find and capture media for it
2. Edit the description field of a different find

*What is the expected output? What do you see instead?*
Expected - only description field of that find should be changed
Actual - the description field changes, and the picture is changed to your 
previously captured media. 

Original comment by brittney...@gmail.com on 22 Jan 2012 at 12:28

GoogleCodeExporter commented 9 years ago
The issue was caused by the CameraActivity maintaining an image throughout the 
changing of finds. In order to fix the issue we added a new method to the 
AddFindPluginCallback interface that would be called upon the finish of a 
FindActivity. The finish callback is performed by all plugins associated with 
the current FindActivity.

Original comment by and.mats...@gmail.com on 22 Jan 2012 at 6:41

Attachments:

GoogleCodeExporter commented 9 years ago
This issue was closed by revision 3be8f4ec42ea.

Original comment by and.mats...@gmail.com on 26 Jan 2012 at 3:19

GoogleCodeExporter commented 9 years ago
The patch appears to fix this issue  However I think it might be good to modify 
the finishCallback() method to include parameters, which may be necessary in 
other cases.  It should at least contain Context and Find, if not the same 
arguments as the other call backs. 

Also, I notice that the edited finds are no longer being marked "Unsynced" in 
the ListFinds.  I don't think it's caused by this patch, but I did just notice 
that.

Original comment by ram8...@gmail.com on 26 Jan 2012 at 3:23

GoogleCodeExporter commented 9 years ago
Added the extra parameters to finishCallback() as described in the previous 
comment.

Original comment by RobIan...@gmail.com on 31 Jan 2012 at 6:01

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by RobIan...@gmail.com on 21 Feb 2012 at 5:28

GoogleCodeExporter commented 9 years ago
This issue was closed by revision 6e867af57db3.

Original comment by RobIan...@gmail.com on 23 Feb 2012 at 12:58