Second review comments - Githubissues

sanzacha / final-capsule-project-app

0 stars 0 forks source link

Second review comments #2

Closed raghuprathap closed 6 years ago

raghuprathap commented 6 years ago

1). Create a Readme.MD file with all instructions to install, test, run application. 2). after npm run serve hitting browser URL with localhost:3000 making network calls to https://final-capsule-project-app.herokuapp.com/users 3). Even after browsing https://final-capsule-project-app.herokuapp.com/ after logging in network calls are throwing 404 not found error. Please check below screenshot. 4). Configure eslint with airbnb. 5). Write unit test cases for React components. 6). Implement Sagas to send / Recieve messages. 7). Heroku deployed app not working after logging in throwing 404 not found error.

sanzacha commented 6 years ago

Hi @raghuprathap, Below points fixed.

Readme.MD file updated
Network call fixed
Heroku deployment is success but getting authentication error in pusher chatKit.

sanzacha commented 6 years ago

Hi @raghuprathap ,

Configured eslint with airbnb. Some of the ESLint error needs to fix. I am working on that.

sanzacha commented 6 years ago

@raghuprathap - Heroku app issue fixed

sanzacha commented 6 years ago

@raghuprathap - Sagas to send / Recieve messages implimented

sanzacha commented 6 years ago

@raghuprathap - ESLint implemented and errors fixed

sanzacha commented 6 years ago

@raghuprathap - Test cases are pending, Bit busy with project. Please close this issue.

sanzacha commented 6 years ago

Code re-factored with review comments, so I am closing this issue. Test cases pending.