search

saopicc / killMS

Package for direction dependent calibration
GNU General Public License v2.0
9 stars 3 forks source link

MS is not conformant #9

Open dentalfloss1 opened 3 years ago

dentalfloss1 commented 3 years ago

Hi, I am attempting to run killMS and I see the following pasted below. I am unsure how to fix this. Attached are the log files. kilMS-373073-err.txt kilMS-373073-out.txt

- 16:24:13 - ClassMS            | MS is non conformant!
Traceback (most recent call last):
  File "/usr/local/bin/kMS.py", line 1245, in <module>
    main(OP=OP,MSName=MSName)
  File "/usr/local/bin/kMS.py", line 516, in main
    GD=GD)
  File "/usr/local/lib/python2.7/dist-packages/killMS/Data/ClassVisServer.py", line 83, in __init__
    self.Init()
  File "/usr/local/lib/python2.7/dist-packages/killMS/Data/ClassVisServer.py", line 126, in Init
    MS=ClassMS.ClassMS(self.MSName,Col=self.ColName,DoReadData=False,ReadUVWDT=ReadUVWDT,GD=self.GD,**kwargs)
  File "/usr/local/lib/python2.7/dist-packages/killMS/Data/ClassMS.py", line 64, in __init__
    self.ReadMSInfo(MSname,DoPrint=DoPrint)
  File "/usr/local/lib/python2.7/dist-packages/killMS/Data/ClassMS.py", line 681, in ReadMSInfo
    raise
cyriltasse commented 3 years ago

Hi sorry for not replying your email before - I'll send you an invite to the kMS/DDF development repo to try it with a newer version and discuss the issue...

cyriltasse commented 3 years ago

Hey Sarah - check this out: https://github.com/cyriltasse/killMS/issues/40

samit97 commented 1 year ago

Hi, I am also getting the same "MS is non-conformant" issue. Can you tell me how you solve the problem?

bennahugo commented 1 year ago

It is raised when not all baselines are present for all times (ie not all the data is on a regular grid). It could be caused by CASA split set to remove fully flagged rows for instance. You will need to repad your data to contain these missing rows (or resplit with the flag set to false)

dentalfloss1 commented 1 year ago

For now, I just commented out the shape checking portion of the kMS code and it seems to run happily after that. Not sure why it would stop everything when the rest of the calibration works just fine.

bennahugo commented 1 year ago

@cyriltasse should comment but I think this breaks assumptions further down in the code. It is probably not safe to comment the check

o-smirnov commented 1 year ago

Yeah check the results very carefully. There are many ways to be non-conformant, and not all of them are necessarily fatal, so the check you commented out may well be a little over-zealous at times... but you're on shaky ground.

dentalfloss1 commented 1 year ago

Noted. I'll compare source measurements after I finish processing.

From: Oleg Smirnov @.> Sent: Tuesday, June 6, 2023 11:10 AM To: saopicc/killMS @.> Cc: Sarah Chastain @.>; Author @.> Subject: Re: [saopicc/killMS] MS is not conformant (#9)

[EXTERNAL]

Yeah check the results very carefully. There are many ways to be non-conformant, and not all of them are necessarily fatal, so the check you commented out may well be a little over-zealous at times... but you're on shaky ground.

— Reply to this email directly, view it on GitHubhttps://github.com/saopicc/killMS/issues/9#issuecomment-1579152315, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AF35E67EQ3GS5BKJZTG57ETXJ5QAJANCNFSM4S2DKJGQ. You are receiving this because you authored the thread.Message ID: @.***>

cyriltasse commented 1 year ago

Yeah - i can't remember why but there was some reason to request for this... I could dig again if it doesn't work for you @dentalfloss1