search

saoudrizwan / Disk

Easily persist structs, images, and data on iOS
MIT License
3.1k stars 170 forks source link

Add Carthage support #3

Closed PPacie closed 7 years ago

PPacie commented 7 years ago

Hi Saoud,

First of, wanted to thank you for the project. It's pretty handy, I will be giving it a chance on my Swift 4 projects for sure =)

I've made it compatible with Carthage.

Any doubts just let me know.

Cheers, Pablo.

saoudrizwan commented 7 years ago

Hey @PPacie, I've never used Carthage before but I just read up on it and figured out how to work with it and added Carthage support to Disk. Thank you for the suggestion, I actually think I may prefer Carthage over Cocoapods now haha! Please let me know if it works.

PPacie commented 7 years ago

Nice 👍

Just didn't understand why you haven't just merged straight away from my PR. Anyway, I have tested your updated version and it worked mint with Carthage =)

Cheers!