search

sap-commerce-tools / ccv2-project-template

Opinionated starter template for any CCv2 project
48 stars 28 forks source link

Improvements to build script for local environment #24

Closed bechte closed 2 years ago

bechte commented 2 years ago

Improvements are:

  1. Make use of authorization header with basic auth, instead of passing username / password to the download task: For some reasons the download was blocked due to an "unauthorized" response. I tried it on bitbucket servers, as well as on github, both refused to pass the configuration forward to SAP. With the authorization header it works fine with both major CI platforms. The Authorization header is calculated based upon the two variables, therefore, this change is backwards compatible and does not require any change in configuration.
  2. Fixed a typo within the download area of the extension packs: The commerce version was referenced, therefore, the download was not found and the build failed.
  3. Add support for local properties within the build script: The build script now supports to generate the symlinks for the local developers and it is easy to extend, by adding more files to the map configuration object.
  4. The local.properties file pointed to ${HYBRIS_CONF_DIR} which could not been resolved on Windows: On some Windows systems the path replacement did not work, because the $HYBRIS_CONF_DIR was not available whilst loading the file. Now the build script sets the absolute path within the local.properties which works very robust on all systems.