search

sap-commerce-tools / sanecleanup

Sensible defaults for data retention and cleanup for SAP Commerce
Apache License 2.0
25 stars 16 forks source link

fix: version pattern for CCv2 build.version #6

Closed thendricks0 closed 2 years ago

thendricks0 commented 2 years ago

CCv2 uses Version pattern "2105.10-2105-2202.26-20220510.1-cbe2a6a-develop" which causes Spring Bean initialization to fail since the current pattern for NEW_VERSION causes .match() to return false so the pods in the CCv2 won't start anymore.

BTW, some of the index definitions in the items.xml will also cause the build to fail because items like DroolsRule and AbstractRule depend on extensions that are not included out of the box like droolsruleengineservices, so I'm not sure if it makes sense to include these per default.

mpern commented 2 years ago

ouch, thanks for catching that one.

regarding drools / rule engine: Drools is the default to do promotions / advanced pricing for quite a while now, that's why it's also included in sanecleanup