search

sap-linuxlab / ansible.playbooks_for_sap

Automation for SAP - Ansible Playbooks for SAP solution scenarios deployment to Infrastructure Platforms
Apache License 2.0
16 stars 15 forks source link

Low Priority: Documentation of Download & Uncompress #14

Open Darryl-G opened 6 months ago

Darryl-G commented 6 months ago

The section here: https://github.com/sap-linuxlab/ansible.playbooks_for_sap/blob/main/docs/GET_STARTED_WINDOWS.md#download Has the following example:

mkdir -p run_playbooks && cd run_playbooks && curl -L https://github.com/sap-linuxlab/ansible.playbooks_for_sap/archive/refs/tags/1.0.0.zip | tar -xzv

But using 1.0.0.zip is not decompressed with tar. Should be:

mkdir -p run_playbooks && cd run_playbooks && curl -L https://github.com/sap-linuxlab/ansible.playbooks_for_sap/archive/refs/tags/1.0.0.tar.gz | tar -xzv

Same for the MacOS section also.

sean-freeman commented 5 months ago

Just a developer's shorthand that covers .tar.gz or .zip for the following long form operators. I didn't think much of this command to be honest, it was after a long day of documentation that I added it.

Does it need to be replaced? I'm not confident of the unzip utility across different OS and whether that will work from a curl pipe. I would have to test.

curl -L https://github.com/sap-linuxlab/ansible.playbooks_for_sap/archive/refs/tags/1.0.0.tar.gz \
| tar --extract --ungzip --verbose
-x, --extract, --get
    Extract  files  from an archive. 

-z, --gzip, --gunzip, --ungzip
    Filter the archive through [gzip](1).

-v, --verbose
    Verbosely  list  files processed.

Source: https://manpages.ubuntu.com/manpages/jammy/en/man1/tar.1.html