search

sap-linuxlab / community.sap_infrastructure

Automation for SAP - Collection of Ansible Roles for infrastructure-related tasks for SAP
Apache License 2.0
4 stars 8 forks source link

sap_vm_temp_vip: hardcoded group names #29

Open rhmk opened 5 months ago

rhmk commented 5 months ago

Currently, this role requires particular group names in the inventory. This needs to be more customized for generic use.

At least the group should be defined as a variable and can default to the now hardcoded names

Ideally, I would prefer a generic role to set a temp IP to "inventory hostname" or similar to get a more generic approach. Just pass current IP or Interface and virtual IP as parameters.

sean-freeman commented 4 months ago

This is due the Ansible Role's genesis, where it was a part of the Ansible Playbooks for SAP project before requested split.

Likely this can be more easily solved by appending new var *_hostname. This would allow a user to specifically define, "this VIP on that HOST". Such as....

  when:
    - sap_vm_temp_vip_hana_primary is defined
    - inventory_hostname == sap_vm_temp_vip_hana_primary_hostname
    - not ansible_chassis_asset_tag == 'ibmcloud'

Change will have to wait until close to sap_infrastructure new release, and require immediate change to AP4S as it is a breaking change.