sap-linuxlab / community.sap_infrastructure

Automation for SAP - Collection of Ansible Roles for infrastructure-related tasks for SAP
Apache License 2.0
4 stars 8 forks source link

sap_hypervisor_node_preconfigure: Replacing multiple occurrence of openshift-cnv with a constant #8

Closed geetikakay closed 3 months ago

geetikakay commented 7 months ago

Replacing multiple occurrence of openshift-cnv with a constant. Consider adding vars.yml In case we need to make changes we just have one place to change.

example:

  tasks:
    - name: Ensure the OperatorGroup is present
      kubernetes.core.k8s:
        state: present
        definition:
          apiVersion: operators.coreos.com/v1
          kind: OperatorGroup
          metadata:
            name: kubevirt-hyperconverged-group
            namespace: "{{ openshift_namespace }}"
          spec:
            targetNamespaces:
              - "{{ openshift_namespace }}"

Would like maintainers to think about this proposal so that i can proceed.

newkit commented 3 months ago

This has been addressed with PR#44.