Closed rhmk closed 2 months ago
I'm inclined to reject the principle behind this PR:
/playbooks/sample-sap-hana-preconfigure.yml
that covers this use caselocalhost
as the end-users laptop and populate targets from comma-separated list of IP Addresses (into var _sap_systems
)/playbooks
is prefixed as sample-
because it is just the beginning of what can be achievedIf this is needed for some downstream purpose to provide Support or cleaner end-user "Just Run This" documentation/functionality, then I would suggest this code is instead added into the vendor-specific fork (aka. midstream).
If this is needed for some downstream purpose to provide Support or cleaner end-user "Just Run This" documentation/functionality, then I would suggest this code is instead added into the vendor-specific fork (aka. midstream).
Having playbooks which can be called directly after installing the collection (including upstream collections) has the following advantages:
README.md
files, reducing their size. These sample playbooks in the README.md
files can be replaced by an ansible-playbook
command and the proper option for calling the interactive playbook.Because we will be leaving the existing sample playbooks with the dashes in their names untouched, existing functionality and scope will remain in place. See also https://github.com/sap-linuxlab/community.sap_install/issues/726 .
@sean-freeman
My intervention is indeed to move away from sample- mid-term and have callable playbooks that can be imported with a few parameters, to do what is needed. I think we can discuss about the "parameter asking playbook" to have this in downstream only, but the _exec playbook is worth putting here.
The PR is BTW a reaction to users who asked for a "directly usable" playbook
Removed the interactive part to provide a vendor-specific version of it and suggest to go forward with this PR. It makes the roles much easier consumable and reusable, e.g. in ansible-playbooks4sap
These are 2 playbooks which are added to the playbooks directory.