Closed MatthiasWinzeler closed 9 months ago
Hi @MatthiasWinzeler thank you for contributing. I will review this PR soon.
@rainerleber many thanks for your feedback! I took care of the obvious comments and added follow-up questions where it was unclear to me how we proceed.
@MatthiasWinzeler thanks for clarify the questions. Only a few things are left :-) after that we are ready to merge I think.
@rainerleber thanks - merged your suggestions and responded your other comments. Can you give it a final review?
@rainerleber FYI, cleanup PR is in https://github.com/sap-linuxlab/community.sap_launchpad/pull/17
This PR adds the functionality discussed in issue https://github.com/sap-linuxlab/community.sap_launchpad/issues/15.
Scope
license_keys
, which allows creating and updating systems and their license keys. It is closely modeled after the interactions in the portal https://me.sap.com/licensekey, meaning that systems and license keys are always updated together (i.e. you cannot just create new license keys, but you have to edit the system, add license keys, and submit everything together).systems_info
, which allows retrieving existing systems (i.e. its system number), so that the system update/license key creation can be done in an idempotent manner (see example below).Example
An example usage of the module which allows to idempotently create or update a system and retrieve the license key file:
I tested the following use cases to ensure full idempotency.
system.nr
, its data attributes are updated and any changed licenses applied. If the licenses had no changes, they are not updated.Let me know if you need more examples (should we create a sample playbook in the repo?), more extensive documentation or other changes. Please also let me know if I have to sign any CLA. Eager to get your feedback!