sap_control_exec unsupported functions

rainerleber commented 6 months ago

Summary

sap_control_exec module uses the XML api. The documentation is kind of missleading as the e.g.StartWait is not available in in the wsdl output.

The supported functions are:

Start Stop Shutdown InstanceStart InstanceStop Bootstrap ParameterValue GetProcessList GetProcessList2 GetStartProfile GetTraceFile GetAlertTree GetAlerts RestartService StopService GetEnvironment ListDeveloperTraces ListLogFiles ReadDeveloperTrace ReadLogFile AnalyseLogFile ConfigureLogFileList GetLogFileList RestartInstance SendSignal GetVersionInfo GetQueueStatistic GetInstanceProperties OSExecute AnalyseLogFiles GetAccessPointList GetSystemInstanceList StartSystem StopSystem RestartSystem AccessCheck GetProcessParameter SetProcessParameter SetProcessParameter2 ShmDetach CreateSnapshot ReadSnapshot ListSnapshots DeleteSnapshots RequestLogonFile GetNetworkId GetSecNetworkId UpdateSystem GetSystemUpdateList UpdateSCSInstance ABAPReadSyslog ABAPReadRawSyslog ABAPGetWPTable ABAPAcknoledgeAlerts CMGetThreadList ICMGetConnectionList ICMGetCacheEntries ICMGetProxyConnectionList WebDispGetServerList WebDispGetGroupList WebDispGetVirtHostList WebDispGeUrlPrefixList EnqGetLockTable EnqRemoveLocks EnqGetStatistic

Issue Type

Bug Report

Component Name

sap_control_exec

Ansible Version

$ ansible --version

community.sap_libs Version

$ ansible-galaxy collection list community.sap_libs

Configuration

$ ansible-config dump --only-changed

OS / Environment

No response

Steps to Reproduce

    - name: Start SAP Instance
      community.sap_libs.sap_control_exec:
        hostname: "{{ ansible_host }}"
        sysnr: "{{ instancenr }}"
        function: StartWait
        parameter: "300 2"
        username: "{{ username }}"
        password: "{{ password }}"

Expected Results

Wait until started

Actual Results

fatal: []: FAILED! => {"changed": false, "error": "Method not found: 'SAPControl.SAPControl.StartWait'", "msg": "Something went wrong connecting to the SAPCONTROL SOAP API.", "out": {}}

Code of Conduct

[X] I agree to follow the Ansible Code of Conduct

rainerleber commented 6 months ago

The list with the supported functions could be found here: https://www.sap.com/documents/2016/09/0a40e60d-8b7c-0010-82c7-eda71af511fa.html from page 63 onwards

rainerleber commented 6 months ago

Action: Remove non supported functions from the list in the module

rainerleber commented 6 months ago

@sean-freeman from my point of view it's not a breaking change because the functions are non functional at all. What do you think ?

sap-linuxlab / community.sap_libs