sap-oc / crowbar-openstack

Openstack deployment for Crowbar
3 stars 1 forks source link

cinder: add nfs_mount_options configuration parameter #42

Closed matelakat closed 6 years ago

matelakat commented 7 years ago

nfs_mount_options is a list of mount options that can be used when cinder is mounting nfs shares for volumes. These options will be applied on all volumes, so it's useful for situations where a share is no longer listed in the nfs_shares list, but cinder still needs to manage volumes living on it. Unfortunately we also had to include this change on the nova side as well.

So people need to set it in two barclamps. Please also note, that these options are global, so you should make sure that those options are compatible with the options listed next to the shares you have in nfs_shares_config.

matelakat commented 7 years ago

Needs to be tested.

matelakat commented 7 years ago

@vuntz could you take a look again? I added some hint help messages as well.

vuntz commented 7 years ago

Btw, make sure to upstream the patch if it's still relevant for newton.

matelakat commented 7 years ago

What we want to check is if we need the same setting on the nova side as well.

matelakat commented 7 years ago

@vuntz this has been updated to include the setting for nova as well. Could you please review?

snschee commented 7 years ago

Hi @matelakat,

I tested the patches successfully in our lab environment. Can you please merge it to master, that we are able to package them.

Thx and br Sebastian

matelakat commented 7 years ago

Ok, re-based, see what CI says