sap-tutorials / Tutorials

Tutorials on sap.com
https://developers.sap.com/tutorial-navigator.html
Creative Commons Attribution 4.0 International
732 stars 778 forks source link

Connect to OData service on Neo using SAP S/4HANA Cloud SDK #2284

Closed niklas1375 closed 6 years ago

niklas1375 commented 6 years ago

Since lombok 1.16.20 there's a problem with the deserialization of the answer from the OData service (see https://github.com/rzwitserloot/lombok/issues/1563). Hence this implementation will throw an error.

thecodester commented 6 years ago

@019a Olga, can you take a look at this?

niklas1375 commented 6 years ago

I managed to create a workaround but it's not pretty. You have to use the JsonDeserializer annotation, create an internal class for this and write your own Constructor with the Builder annotation (for reference see the linked issue). I know that the error is not your fault but I thought you'd like to know.

019a commented 6 years ago

Thank you for the feedback and for bringing this to our attention! In the latest version of the tutorial, available from https://blogs.sap.com/2017/05/21/step-4-with-sap-s4hana-cloud-sdk-calling-an-odata-service/, we no longer use Lombok directly but propose to use the Java virtual data model (VDM) of the SAP S/4HANA Cloud SDK. Thus, the issue does not occur there.

thecodester commented 6 years ago

Thank you for your feedback. The issue seems to be resolved, so I am closing the issue.

If you still have questions, feel free to reopen the issue.