sapcc / elektra

An opinionated openstack Web UI for consumer self service and operations.
Apache License 2.0
73 stars 29 forks source link

DNS zone UI: incorrect error messages #1262

Open corey-aloia opened 1 year ago

corey-aloia commented 1 year ago

Maybe just another thought: why have the prefix API: in the error message? Sometimes it is API: provided object is not valid. Does this help an end user? I would expect from a UI that there is a mapping of input box - to error message. For example, if the "name" is incorrect, then I would either expect to see this in the error message, or have the input box itself turn red. This brings up the idea of calling the dns zone tld as "name". Potentially this should just be "TLD" as name to me indicates that it has no bearing on functionality, but is just a name.

edda commented 1 year ago

So the problem here is that all those error messages that are prefixed with Api: are error messages that are returned by the API, so Designate in this case. In those cases we typically don't have the context information that would allow us to e.g. mark the input of the value that produced the error as you suggest. All we get is the error String.

I like your suggestion to change the label from just Name to maybe something like Name (TLD), as that would help with some of the error messages. Also if TTL is indeed mandatory, I agree that we should change this.

edda commented 1 year ago

Maybe it would be a good idea to collect the most common error messages and their causes and add this information to the user documentation.