sapcc / helm-charts

Helm charts for SAP Converged Cloud managing openstack on kubernetes
Apache License 2.0
35 stars 62 forks source link

[utils/mysql] Replace Global Master Password #2294

Closed BugRoger closed 3 years ago

BugRoger commented 3 years ago

https://github.com/sapcc/helm-charts/blob/master/openstack/utils/templates/_hosts.tpl#L130

Prior Art: https://github.com/sapcc/helm-charts/commit/a4c48f4160d81b1f3bbdb356f7526c431763ca4a Take note that this utility function is being used in many other charts:

BugRoger commented 3 years ago

@Carthaca @rajivmucheli We still have a transitive dependency to the master_password in this utility function.

I suggest we delete the function: https://github.com/sapcc/helm-charts/blob/0c26619ebb462261149801e561b0ec8342306fde/openstack/utils/templates/_hosts.tpl#L125-L131

and replace each occurance with a similar require as was used here:

required ".Values.global.bigip_user required!") ( $envAll.Values.global.bigip_password | required ".Values.global.bigip_password required!"
rajivmucheli commented 3 years ago

Hi @BugRoger,

  1. cinder & nova service need to merge/rollout the PR's mentioned in #2293, until then we cannot fix #2294.
  2. The above format is already being implemented in #2293, example : https://github.com/sapcc/helm-charts/pull/2348/files