sapcc / juno

Monorepo for the Juno microfrontend framework, microfrontend apps, design system and component library
Apache License 2.0
5 stars 3 forks source link

[Juno] Create app script errors #445

Closed edda closed 2 weeks ago

edda commented 8 months ago

We have a report that the juno CLI create app skript throws some errors:

$ bin/juno create app maillog --external   
creating external app maillog
sed: RE error: illegal byte sequence
sed: RE error: illegal byte sequence
sed: RE error: illegal byte sequence
sed: RE error: illegal byte sequence
remove peerDependencies
link communicator to https://assets.juno.global.cloud.sap/libs/communicator@latest/package.tgz
link juno-ui-components to https://assets.juno.global.cloud.sap/libs/juno-ui-components@latest/package.tgz
...

The resulting package.json doesn't have the proper replacements made for our libs, example:

"juno-ui-components": "^2.5.2",

version number instead of the assets server link

And also apparently the script duplicates all files in the root folder (every file, e.g. package.json, esbuild.config.js, .... is duplicated)

edda commented 8 months ago

Seems to be a problem of the bash script doing different things in Linux than other OSes