[supernova]: small ui improvements - Githubissues

sapcc / juno

Monorepo for the Juno microfrontend framework, microfrontend apps, design system and component library

Apache License 2.0

5 stars 3 forks source link

[supernova]: small ui improvements #487

Closed ArtieReus closed 5 months ago

ArtieReus commented 7 months ago

[ ] 1. Remove fetch error when new data is posted back from worker
[ ] 2. Improve fetch error with Error Code and if possible with error status aswell
[ ] 3. Sort filter labels in the dropdown. After a rework status appears at the beginning

TilmanHaupt commented 5 months ago

Do you know if this issue is already solved? What is the context?

ArtieReus commented 5 months ago

(3). Sort filter labels in the dropdown. After a rework status appears at the beginning

ArtieReus commented 5 months ago

(2) See error handling here:

api fetch error catch and callback: https://github.com/sapcc/juno/blob/main/apps/supernova/src/api/apiService.js#L48
worker post error message: https://github.com/sapcc/juno/blob/main/apps/supernova/src/workers/alerts.js#L60 https://github.com/sapcc/juno/blob/main/apps/supernova/src/workers/silences.js#L31
receive error message and save https://github.com/sapcc/juno/blob/main/apps/supernova/src/hooks/useAlertmanagerAPI.js#L75 https://github.com/sapcc/juno/blob/main/apps/supernova/src/hooks/useAlertmanagerAPI.js#L114
display error: https://github.com/sapcc/juno/blob/main/apps/supernova/src/AppContent.jsx#L82 https://github.com/sapcc/juno/blob/main/apps/supernova/src/AppContent.jsx#L73

ArtieReus commented 5 months ago

(1) On new data received from worker we should remove error messages we may been displayed from past fetches: https://github.com/sapcc/juno/blob/main/apps/supernova/src/hooks/useAlertmanagerAPI.js#L65C13-L65C26 https://github.com/sapcc/juno/blob/main/apps/supernova/src/hooks/useAlertmanagerAPI.js#L100