search

sapcc / juno

Monorepo for the Juno microfrontend framework, microfrontend apps, design system and component library
Apache License 2.0
7 stars 2 forks source link

[juno-ui-components] TabNavigation attribute `activeTab` throws a warning and does not work #505

Closed ArtieReus closed 8 months ago

ArtieReus commented 8 months ago

react-dom.development.js:86 Warning: React does not recognize the activeTab prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase activetab instead. If you accidentally passed it from a parent component, remove it from the DOM element.

ArtieReus commented 8 months ago

ok it seems the documentation is not up to date. I found in Supernova following

activeItem={selectedItem} onActiveItemChange={handleTabSelect}>

which it isn't what is documented here: https://ui.juno.global.cloud.sap/?path=/docs/navigation-tabnavigation-tabnavigation--docs

onTabChange !== onActiveItemChange activeTab !== activeItem

ArtieReus commented 8 months ago

So I can see that I have created the issue before the commit from Franz came in: https://github.com/sapcc/juno/commit/7a234827e3ce39188b76478e2c0404b78960995e

We can close this topic since the documentation is changed.