sapcc / juno

Monorepo for the Juno microfrontend framework, microfrontend apps, design system and component library
Apache License 2.0
5 stars 3 forks source link

[ui] DateTimePicker: add correct dateFormat to story #566

Closed franzheidl closed 3 months ago

franzheidl commented 3 months ago

Closes #563.

Issue 1 – browser warning re non-conforming value in minute input when enableTime is set to true Set the default minuteIncrement to 1, thus preventing the first issue descried.

Issue 2 – onChange handler not firing every time when value (time) changes Add heuristic to determine a working default dateFormat depending on enableTime, enableSeconds, and noCalendar. As a result, users should never have to set a dateFormat themselves in order to have a working component. They are still free to set a custom date format that suits their needs.

Issue 3 – defaultHour and defaultMinute Rename the story not raise wrong expectations, update/clarify the respective prop and story descriptions.