search

sapcc / juno

Monorepo for the Juno microfrontend framework, microfrontend apps, design system and component library
Apache License 2.0
5 stars 3 forks source link

[Supernova] Silence Scheduler for Supernova #579

Closed TilmanHaupt closed 2 months ago

TilmanHaupt commented 2 months ago

Add a form to schedule silences for e.g. maintenance.

fixes #398

ArtieReus commented 2 months ago

When opening the Template form without selecting any template you can still press save and an error will be displayed. I will propose to disable the save button until the template is selected. What do you think?

ArtieReus commented 2 months ago

If the template have same title the select displays the two templates selected. This is probably because the key is the title. I would recomend to create unique ids (index) to avoid it.

ArtieReus commented 2 months ago

Check how the key status is used in the old Supernova. Ex: 

"status": "active",
ArtieReus commented 2 months ago

Validate template input. Changing for example editable_labels as string crashes the component.