The new github action to automatically insert SAP copyright and Apache license information into all of our files uses the wrong comment format for .mdx files (html styles <!-- --> comments).
This causes building/running storybook, the environment we use to develop juno-ui-components, to fail.
The proper comments are /* */ or /_ _/ comments. I have fixed these for now manually, but I would expect the new github action to automatically insert the info into any newly created .mdx file, so we need to make sure to use the correct comment syntax in the action.
To check whether storybook runs correctly, you can use npm --w juno-ui-components run storybook.
The new github action to automatically insert SAP copyright and Apache license information into all of our files uses the wrong comment format for
.mdxfiles (html styles<!-- -->comments).This causes building/running storybook, the environment we use to develop juno-ui-components, to fail.
The proper comments are
/* */or/_ _/comments. I have fixed these for now manually, but I would expect the new github action to automatically insert the info into any newly created.mdxfile, so we need to make sure to use the correct comment syntax in the action.To check whether storybook runs correctly, you can use
npm --w juno-ui-components run storybook.