search

sapcc / manila

Shared filesystem management project for OpenStack.
http://openstack.org
Apache License 2.0
0 stars 2 forks source link

Fix count response of shares/snapshots list API #130

Closed kpawar-sap closed 1 year ago

kpawar-sap commented 1 year ago

Share/Snapshot list API return count of shares/snapshots. But it return the wrong count as it consider ShareInstances/SnapshotInstances. So filter queries by unique share_id/snapshot_id.

kpawar-sap commented 1 year ago

Aligned with upstream PR https://review.opendev.org/c/openstack/manila/+/893345

Carthaca commented 1 year ago

I think it makes sense to add a unit test case for this calculation

kpawar-sap commented 1 year ago

I think it makes sense to add a unit test case for this calculation

added test