search

sapcc / manila

Shared filesystem management project for OpenStack.
http://openstack.org
Apache License 2.0
0 stars 2 forks source link

Fix deferred deletion get query #171

Closed kpawar-sap closed 4 months ago

kpawar-sap commented 4 months ago

Since share instance get call runs in periodic task which run in each manila-share service instance, we better optimize query to consider only current host. This will improve performance.

Carthaca commented 4 months ago

Imho this is not just about performance, but it is also a bug in the functionality that is fixed here. The commit message should include this aspect, please. I.e. no more orphans due to deferred deletions on the wrong host (which assumed the backend share had already gone, because it was not found - but it was not found because the job looked on the wrong backend)

edit: Goutham came up with a good wording at https://review.opendev.org/c/openstack/manila/+/917960/2/releasenotes/notes/optimize-deferred-deletion-get-share-instance-query-b6366b7c3b0a64db.yaml#6