search

sapcc / manila

Shared filesystem management project for OpenStack.
http://openstack.org
Apache License 2.0
0 stars 2 forks source link

delete ports before share server deletion #173

Closed kpawar-sap closed 4 months ago

kpawar-sap commented 5 months ago

Share server deletion if causes any exception, Manila end up having orphaned ports. So first deallocate network and then proceed with share server deletion.

Change-Id: Ibba5326177417bb4e56c19c59040c40b7886d58b

kpawar-sap commented 5 months ago

I suggest to move it a few lines further down, right after updating the status to constants.STATUS_DELETING.

If something goes wrong, we know, that we started the steps of the share server delete process already...

Otherwise that share server may stay in active state, but with parts of the network_allocation already gone, which might be confusing.

Done

chuan137 commented 5 months ago

we could move it into the try block under?

kpawar-sap commented 5 months ago

we could move it into the try block under?

that is also fine. I moved in try block.

kpawar-sap commented 5 months ago

another commit pushed which is potential fix of https://github.wdf.sap.corp/cc/manila-issues/issues/39. @Carthaca @chuan137 please review

kpawar-sap commented 5 months ago

upstream issue - https://bugs.launchpad.net/manila/+bug/2067266