ccloud: remove check last transfer size in update_replica_state

sapcc / manila

Shared filesystem management project for OpenStack.

http://openstack.org

Apache License 2.0

0 stars 2 forks source link

ccloud: remove check last transfer size in update_replica_state #174

Closed chuan137 closed 4 months ago

chuan137 commented 5 months ago

The check implemented in https://github.com/sapcc/manila/commit/9bd0fc9. But the check leaves replica in out-of-sync state for those with frequent data changes. This pull request removes the check in `update_replica_state'. The replication status check will be implemented in promoting replica in a different PR.

Change-Id: If16a92460a3c1debc217755075f7578c515d89f6

chuan137 commented 5 months ago

split to, and wait for https://github.com/sapcc/manila/pull/175, where improvement for replica promotion taken care of

kpawar-sap commented 5 months ago

please also create upstream pr and maintain sync.

chuan137 commented 5 months ago

I realised that we could set a very large number for netapp_snapmirror_last_transfer_size_limit and disable the check effectively. I think @Carthaca has done it once before.

Carthaca commented 5 months ago

Right, did this in the past via https://github.com/sapcc/helm-charts/commit/16949cf7bf650395086f3ce48c8a3e288729a8cc