Closed Carthaca closed 3 months ago
the
continue
in the attempt loops does not seem to have effect, but it also does not hurt I think, so LGTM
Right, I just copy&pasted the pattern, it could be removed everywhere (configure cifs, set preferred dc, dns create) :)
dc config validation may fail, because network connectivity is not given at that point of setup
run another round with the different discovery modes: to keep current behaviour in the game (previously we only set those after cifs-server-create?)
Change-Id: Ia28721444c596878f77a34e204ec9fe9a8a1e714