search

sapcc / ntp_exporter

Prometheus exporter for NTP offset/stratum of a client
Apache License 2.0
50 stars 17 forks source link

added support for get parameters #11

Closed dhalturin closed 5 years ago

dhalturin commented 5 years ago

Hello. This pull request adds the ability to pass data through the ntp server from get parameters.

For example run with key -ntp.source http and get exporter data: http://_host_:_port_/metrics?server=10.5.255.101&protocol=4&duration=30s

This allows you to run one instance and get multiple ntp servers.

Signed-off-by: Denis Halturin dhalturin@hotmail.com

dhalturin commented 5 years ago

@auhlig, you can check this pull request?

majewsky commented 5 years ago

I have this on my list. Please don't ping additional people. Thanks.

dhalturin commented 5 years ago

@majewsky, okay, sorry )

majewsky commented 5 years ago

There is a lot going on here, which is mostly due to my neglecting this repo for a long time. I've brought this repository up to my team's current conventions, including many of the things that you also did in this PR (like switching to go mod). Please rebase your PR onto dbe4fdde3c, that should make it much more reviewable.

Also, please do not delete the vendor directory. I always make a point of keeping those in my repo since I've been burned a few times by upstream repos just going away all of a sudden.

dhalturin commented 5 years ago

@majewsky i'm done.. can check the pull request.