add includeWithDependencies functionality

sapegin / grunt-bower-concat

Bower components concatenator for Grunt

MIT License

220 stars 72 forks source link

add includeWithDependencies functionality #53

Closed toddzebert closed 9 years ago

toddzebert commented 9 years ago

Per the discussion https://github.com/sapegin/grunt-bower-concat/issues/52

I've tested this locally, and works as expected.

There's really only two line changes to the code:

Add the default option value
Short circuit the logic that would normally skip dependency inclusion when using the include directive.

I also added to the Readme.

There were no tests for include so there was nothing to change.

toddzebert commented 9 years ago

Hey @sapegin I was wondering your thought on if this will make it into prod, or if you have any other questions? Thanks.

sapegin commented 9 years ago

Sorry for the delay, I’ll do that soon :shipit:

toddzebert commented 9 years ago

Hey @sapegin I was wondering if you had any issue with this functionality, or if it might get merged in, thanks!

sapegin commented 9 years ago

I have issues with time ;-)

toddzebert commented 9 years ago

Ha, I hear ya! Thanks - don't mean to push, just wanted to make sure it wasn't waiting on me.

sapegin commented 9 years ago

I’ve added some tests (f0bf122f1043a09eafa2c349f42f1448be6fd45e) and it works as I wrote in a comment before: when includeWithDependencies is enabled it ignores include option which is wrong.