search

sapegin / grunt-webfont

SVG to webfont converter for Grunt
MIT License
1.1k stars 210 forks source link

No explicit mixing for LESS #310

Closed braver closed 8 years ago

braver commented 8 years ago

Addresses #309

Additionally, I moved the font-family in the bem template to the :before pseudo element. Having it on the .icon element is unnecessary and tends to cause issues (the bootstrap template already has it like ehit).

sapegin commented 8 years ago

Thanks but now we have 16 failing tests.

braver commented 8 years ago

Grunt test failed on a clean checkout, so I didn't check it for my changes. I don't mind digging into the tests, but it's not clear from the docs what I should run?

sapegin commented 8 years ago

No, they are fine in master and there are instructions how to run tests.

braver commented 8 years ago

Sorry, my bad, must've overlooked something. I'll fix it!

braver commented 8 years ago

All green now!

The mixinPrefix is now no longer used in LESS, not sure if that needs to be reflected somewhere.

sapegin commented 8 years ago

Cool, thanks!

laurenskling commented 8 years ago

mixinPrefix is still in the documentation, it's not used anymore?