search

sapegin / grunt-webfont

SVG to webfont converter for Grunt
MIT License
1.11k stars 210 forks source link

v1.3.1 - Build Failed on Windows #332

Open jeradrutnam opened 8 years ago

jeradrutnam commented 8 years ago

Checked latest release 1.3.1 and noticed it breaks the build. And the change that cause this issue is,

grunt-webfont\tasks\engines\fontforge.js
var exec = require('exec'); => require('child_process').exec;

var args = [ 'fontforge', '-script', path.join(__dirname, 'fontforge/generate.py')    
];   =>   ].join(' ');

If you revert that, it will work just fine. :)

Can send a PR if you think of reverting it back.

jeradrutnam commented 8 years ago

Hi @sapegin, Just checking about the issue. Are we going to change it or will this effect something else?

sapegin commented 8 years ago

I can’t revert it because exec module is deprecated. There should be a correct solution.