search

sapegin / grunt-webfont

SVG to webfont converter for Grunt
MIT License
1.1k stars 210 forks source link

Allow unique fontFamilyName #338

Closed aaronshekey closed 8 years ago

aaronshekey commented 8 years ago

This pull request allows you to specify a unique fontFamilyName that's independent of the filename.

We ran into wanting this over at https://github.com/primer/octicons/pull/91

fontFamilyName should just fall back to font so it shouldn't break anything if fontFamilyName isn't set in the options.

Am I missing anything?

sapegin commented 8 years ago
  1. Does it work with the node engine?
  2. Would be nice to have tests and docs.
  3. Please also check Travis CI logs.
aaronshekey commented 8 years ago

This should be in better shape, @sapegin. Any other feedback? Any other noob moments? :smile:

sapegin commented 8 years ago

Cool, thanks!