search

sapegin / grunt-webfont

SVG to webfont converter for Grunt
MIT License
1.11k stars 210 forks source link

.eot files not generated #367

Open julkue opened 7 years ago

julkue commented 7 years ago

.eot files aren't generated for me. However, there are correctly added to @font-face. This is my configuration:

    webfont: {
      icons: {
        src: './src/icons/*.svg',
        dest: './public/compiled/fonts',
        destCss: './src/components/_common/',
        options: {
          syntax: 'bootstrap',
          engine: 'fontforge',
          stylesheets: ['scss'],
          htmlDemo: false,
          relativeFontPath: '/compiled/fonts/',
          types: ['eot', 'woff2', 'woff', 'ttf', 'svg'],
          order: ['eot', 'woff2', 'woff', 'ttf', 'svg'],
          template: './config/icon-template.config.css'
        }
      }
    },

It doesn't metter if I remove types ad order or not.

syarul commented 7 years ago

I think this related to #356 issue, which avoid generating eot files. You might want to use previous version if you need the eot

acuntex commented 7 years ago

Still not working in 1.7.1.

syarul commented 7 years ago

the node engine has no issue generating the .eot, might as well use that.

lqez commented 5 years ago

356 should be rollbacked. Invoking join method with bytes and non-bytes string causes problem.

TypeError: sequence item 0: expected str instance, bytes found

Since Python 3, bytestring / bytes should be handled differently and Python 2.7 does not care about b notation. Thus, b''.join(...bytes...) was right.

I successfully built eot files with b''.join(...bytes...).