search

sapegin / react-spaceman

React component to manage whitespace
https://sapegin.github.io/react-spaceman/
60 stars 8 forks source link

Change the component name from `Panel` to `Space` #3

Closed julius-retzer closed 6 years ago

julius-retzer commented 6 years ago

What's the reasoning behind naming the component Panel?

For me Panel is a different UI component, something like this Material Desgin Panel

I think Space would better suit the purpose of the component, would not conflict with already existing UI components and it reads quite nicely: <Space between="s">

I know I'm free to give it any alias I want in my code, but I think there's a solid ground for reconsidering.

sapegin commented 6 years ago

I think Space would better suit the purpose of the component, would not conflict with already existing UI components and it reads quite nicely:

It reads like “space between s” which is very misleading.

I know I'm free to give it any alias I want in my code, but I think there's a solid ground for reconsidering.

I don’t see any reason to change it for now, and Space is a worse name than Panel. It is a panel that defines some spacing rules for its children, not the space itself.

Feel free to use any name use like when importing component.