search

saphir746 / BiobankRead-Bash

Python scripts to extract and pre-process UKB data
GNU General Public License v3.0
30 stars 8 forks source link

installation instructions, release, pip package #10

Closed antoniojbt closed 5 years ago

antoniojbt commented 5 years ago

Hello! Looks great, you may want to provide instructions for installation, make it pip install-able and add a release in GitHub? It already has a setup.py so might be that the instructions are incomplete at the moment? Best, Antonio

antoniojbt commented 5 years ago

Further to the above: re comes by default with python so no need to specify it as an additional dependence (I forgot so tried conda then pip and couldn't find it). You could maybe add eg:

conda create -n biobankread
conda activate biobankread
conda install -y python pandas beautifulSoup4 urllib3 seaborn
pip install biobankread

to the instructions.

Also, just noticed your setup.py is empty. I have a more involved template which is useful if you want to install scripts that run from the command line. Would you be happy accepting pull requests? I could try adding some of these files if helpful. Best, Antonio

saphir746 commented 5 years ago

Added - conda usage example to README.txt

saphir746 commented 5 years ago
antoniojbt commented 5 years ago

👍