search

sapiens / SqlFu

Fast and versatile .net core data mapper/micro-orm
Other
229 stars 50 forks source link

Making GetPocoMapper public instead of internal #76

Closed SimplyAdam closed 8 years ago

SimplyAdam commented 8 years ago

This would give greater flexibility in extending the Fetch method. In my example, I'm pulling total row counts on paged queries within stored procedures that can't be outputted via traditional SP output parameters. This little bit of flexibility means I can re-use the super fast poco mapper already in SqlFu but still have the access to the data reader to grab additional information that I need. It would also mean I can create a custom generic query across all my objects by reusing all the work SqlFu already does.

It would be really powerful, and all that is need is access to is the GetPocoMapper method.

sapiens commented 8 years ago

Adam, please make the PR for sapiens:devel branch. 'master' is only for released code. Thank you.

SimplyAdam commented 8 years ago

Sorry.. I've corrected this now. Hopefully this is something that could be pushed into release for v2.

Will be looking at v3 soon too so I can replace Fetch with the new QuerySProc. :+1: