sapiens / SqlFu

Fast and versatile .net core data mapper/micro-orm
Other
229 stars 50 forks source link

Suggestion: Remove Dependency on Caveman Tools or Fix Namespacing in that Library #8

Closed ventaur closed 12 years ago

ventaur commented 12 years ago

I've already left a suggestion on the Caveman Tools repo, but felt it necessary to also create a suggestion on SqlFu.

I don't really mind the dependency on another library. However, I was taken aback by the automatic inclusion of the Caveman Tools extension methods. This is simply because Caveman Tools extension methods are piggy-backing onto the System and System.* namespaces.

Not only is my Intellisense polluted, but I have to take extra steps to strip out those extension methods from my project's auto-generated documentation.

My suggestion is to either remove the dependency on Caveman Tools and/or fix the namespacing that it uses. Instead of rooting those extension methods in System, I would really recommend rooting them in their own CavemanTools namespace.

To ensure this comes across as true feedback, and not just negativity, I'd like to thank you for your hard work on this library. I used Dapper.net on another project, but SqlFu has made life even easier (especially, for small projects).

Thanks,

-Matt

sapiens commented 12 years ago

SqlFu requires CavemanTools. Now, from my testing, if you're not using CavemanTools explicitly but only SqlFu, then you don't get the extensions or any CT related stuff. I think that nuget adds a reference to all libraries by default so you can remove the CavemanTools reference from your project and use only Sqlfu. That should solve your problem.