search

sapientml / core

A SapientML plugin of SapientMLGenerator
Apache License 2.0
10 stars 12 forks source link

fix: Add LabelEncoder while using XGBClassifier and MultiOutputClassifier #59

Closed ihkao closed 5 months ago

ihkao commented 7 months ago

Close #29

Following discussions with tahalpara, I will be taking charge of this PR.

The primary focus of these enhancements is to bolster support for multi-output classification and regression tasks and to streamline the handling of multiple target columns for increased efficiency and effectiveness.

AkiraUra commented 5 months ago

@ihkao I've approved your modification, but a test case failed. Could you modify your code or test code to pass the test?

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (main@bbf680a). Click here to learn what that means.

:exclamation: Current head 85e3c77 differs from pull request most recent head 089ff36. Consider uploading reports for the commit 089ff36 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #59 +/- ## ======================================= Coverage ? 63.76% ======================================= Files ? 36 Lines ? 2848 Branches ? 0 ======================================= Hits ? 1816 Misses ? 1032 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ihkao commented 5 months ago

I have solved the test case failures. However, there are some new issue with evaluation_test.py.jinja while operating multilabel datasets. Please onhold the PR till I fix the issue. Thank you.

ihkao commented 5 months ago

@ihkao I've approved your modification, but a test case failed. Could you modify your code or test code to pass the test?

All test has passed and assert in evaluation_test.py.jinja has been fixed.

ihkao commented 5 months ago

Just add sign with gpg.