search

sapientml / core

A SapientML plugin of SapientMLGenerator
Apache License 2.0
10 stars 12 forks source link

fix: ValueError target column of train dataframe has NaN or Inf. #67

Closed arima-tsukasa closed 3 months ago

arima-tsukasa commented 5 months ago

@AkiraUra

The Inf check in the target column was deleted because it had already been performed elsewhere.

This PR is a part of the following PRs.

Please take a review on it.

kimusaku commented 3 months ago

@arima-tsukasa it seems several commits in the PR are not signed and thus the PR cannot be merged so far. Can you please sign each commit according to https://github.com/sapientml/sapientml/blob/main/CONTRIBUTING.md#i-did-not-sign-my-commit-now-what ? Thanks.

arima-tsukasa commented 3 months ago

@arima-tsukasa it seems several commits in the PR are not signed and thus the PR cannot be merged so far. Can you please sign each commit according to https://github.com/sapientml/sapientml/blob/main/CONTRIBUTING.md#i-did-not-sign-my-commit-now-what ? Thanks.

The signature of merging the main modification was missing. We have taken measures.

arima-tsukasa commented 3 months ago

@AkiraUra

We have taken additional measures based on the following PR.

The following fixes have been incorporated into the PR fixes.