sapientml / core

A SapientML plugin of SapientMLGenerator
Apache License 2.0
10 stars 12 forks source link

fix: Fix error that occurs when special characters are removed from column names #78

Open tashiro-akira opened 2 months ago

tashiro-akira commented 2 months ago

@AkiraUra @kimusaku Add action to eliminate duplicate column names when special characters are removed.

The results of the review were reflected.

・Review Comments   Thank you for the PR. The code of rename_dict is duplicated from the preprocess one.   Could you consider a way of removing the duplication?      ・Corrected content     The processing to modify the column name is now a common plug-in.

・Review Comments   The current method fails when the renamed names are the same as original names.   For example, there are original columns Age , Age{} and Age1.   In the case, Age -> Age1, Age{} -> Age0, so there are two Age1 columns.   Could you consider the case?      ・Corrected content     Fix column renaming to add a random number after the column name.     Add handling to rename a column if it is re-duplicated after renaming the column.