search

sapierens / firefox-edge

Firefox Edge is a theme for Mozilla Firefox that closely replicates the look of Microsoft Edge (dark theme) without losing any features of Firefox.
Other
63 stars 6 forks source link

Issues on Linux Mint #5

Closed dominichayesferen closed 7 years ago

dominichayesferen commented 7 years ago

The close tab button, as well as the History Button on the Address Bar, are bugged, I'll show you what I mean: screenshot from 2016-12-01 14-11-39 screenshot from 2016-12-01 14-11-59

Apart from that and the buttons sticking out on hover, working really well!

dominichayesferen commented 7 years ago

...also, ignore the white patch, that's because of my GTK Theme...

sapierens commented 7 years ago

This is fixed in the next patch, but I still see other minor visual bugs. Looks like they occur because Firefox on Linux is using a slightly different base CSS for appearance than on Windows. So I don't think I can do much about other minor bugs.

dominichayesferen commented 7 years ago

@sapierens Hmm, not seeing anything different on Firefox on Mint 18.1 BETA: screenshot from 2016-12-05 18-17-53

ghost commented 7 years ago

I'd like it on ... Linux. On Dec 5, 2016 8:18 PM, "feren CEO" notifications@github.com wrote:

@sapierens https://github.com/sapierens Hmm, not seeing anything different on Firefox on Mint 18.1 BETA: [image: screenshot from 2016-12-05 18-17-53] https://cloud.githubusercontent.com/assets/11057934/20896768/27a49822-bb17-11e6-93cf-5c4b4688d413.png

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/sapierens/firefox-edge/issues/5#issuecomment-264932195, or mute the thread https://github.com/notifications/unsubscribe-auth/AO6gTZJaelQCt3cRii-b6hHnEF4-UNDxks5rFFVbgaJpZM4LBb_3 .

sapierens commented 7 years ago

@sapierens Hmm, not seeing anything different on Firefox on Mint 18.1 BETA:

The update is not out yet but it will be in the next couple of days. I still have to finish some other things.

sapierens commented 7 years ago

I'd like it on ... Linux.

I'll take another look at it before this patch releases, but if some of the required changes will conflict with Firefox on Windows, I'll have to keep those fixes out.

sapierens commented 7 years ago

Looks like I actually managed to fix all the visual bugs (that I could spot) without interfering with Windows version of Firefox.

ghost commented 7 years ago

Looks like I actually managed to fix all the visual bugs (that I could spot) without interfering with Windows version of Firefox.

@sapierens @feren

Should I understand it now also works with Firefox on Linux?

sapierens commented 7 years ago

Yes, most of the visual bugs have been sorted for the Linux version. There are still a few on the bookmarks toolbar, but it's all minor stuff. The update with better Linux support is now live on userstyles.

dominichayesferen commented 7 years ago

Fixed thanks!

ghost commented 7 years ago

@sapierens Great job. Kinda like the minimalism of Preject Spartan which gave birth to Edge. As said, kinda like the UI in Edge. It's just the underlying code that I'm suspicious of. Therefore your Edge theme for Firefox is a great accomplishment. Thanks!