search

sapioit / phpliteadmin

Automatically exported from code.google.com/p/phpliteadmin
1 stars 0 forks source link

remove get_magic_quotes_gpc support #187

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
this is old as fuck. why should you care about dinosaurs?

Original issue reported on code.google.com by ykoro...@gmail.com on 5 Mar 2013 at 9:18

GoogleCodeExporter commented 9 years ago 
Although today, magic quotes is usually turned off (thank god), it is still 
possible to enable it up to PHP 5.4. (where it was removed). It was not even 
marked deprecated in PHP 5.2, which we still support! So it's okay if users 
still have magic_quotes enabled (although it generally is a bad idea).
So I'd say we keep this as long as we support PHP < 5.4.
It doesn't hurt anybody.

Feel free to request this again once drop support for PHP 5.3.

Original comment by crazy4ch...@gmail.com on 7 Mar 2013 at 12:12

GoogleCodeExporter commented 9 years ago 
you can simply FORCE people to turn it off, or force GPC off through code,
no one is supporting GPC today.

Original comment by ykoro...@gmail.com on 7 Mar 2013 at 6:59

GoogleCodeExporter commented 9 years ago 
but yes, it doesn't hurt, just some dead code

thanks

Original comment by ykoro...@gmail.com on 7 Mar 2013 at 7:02

GoogleCodeExporter commented 9 years ago 
but yes, it doesn't hurt, just some dead code

Original comment by ykoro...@gmail.com on 7 Mar 2013 at 7:02

GoogleCodeExporter commented 9 years ago 
"or force GPC off through code"
How would you do that? You can't, because it cannot be configured at runtime.

Original comment by crazy4ch...@gmail.com on 7 Mar 2013 at 12:13

GoogleCodeExporter commented 9 years ago 
I meant something like "you have GPC enabled, disable it'

anyway, it is not critical.. just saw it.

Original comment by ykoro...@gmail.com on 7 Mar 2013 at 4:21

GoogleCodeExporter commented 9 years ago 
Hmm. Of course this would be an option. I think we already do this with 
register_globals (although I don't see the real reason here - see related issue 
#15).

Are there many other popular scripts that don't support magic quotes any longer?

Original comment by crazy4ch...@gmail.com on 7 Mar 2013 at 9:31