codecov[bot]
commented
2 years ago Codecov Report
Merging #415 (f211a50) into master (6ceef8e) will decrease coverage by
0.14%. The diff coverage is88.33%.
@@ Coverage Diff @@
## master #415 +/- ##
==========================================
- Coverage 98.18% 98.04% -0.15%
==========================================
Files 37 37
Lines 4517 4547 +30
==========================================
+ Hits 4435 4458 +23
- Misses 82 89 +7 | Impacted Files | Coverage Δ | |
|---|---|---|
| lib/Storage.js | 89.81% <84.78%> (-0.76%) |
:arrow_down: |
| core/loadCustomTags.js | 100.00% <100.00%> (ø) |
|
| drivers/db/Memory.js | 99.11% <100.00%> (+0.01%) |
:arrow_up: |
| hooks/sapling/user/recover.js | 100.00% <100.00%> (ø) |
|
| hooks/sapling/user/register.js | 98.09% <100.00%> (ø) |
|
| hooks/sapling/user/update.js | 100.00% <100.00%> (ø) |
|
| lib/Response.js | 98.46% <100.00%> (-0.05%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 6ceef8e...f211a50. Read the comment docs.
Instead of returning just the dry array of data from Storage methods, return an object that contains
dataand acountfor the total count of records returned. This opens up opportunities for further metadata to be included later.Still a bit woolly around how the
deletemethod communicates data-less success, but this can be improved later.The MongoDB driver will have to change a little bit too to accommodate these adjustments.
Closes #171.