search

sapmentors / lemonaid

SAP Mentors Lemonaid
MIT License
29 stars 16 forks source link

No pin drop in map for Malaysia address #23

Closed engswee closed 7 years ago

engswee commented 8 years ago

My address is based in Malaysia, but I can't find any pin drop when in the "list everyone" view or even when the search filter has my name filtered.

screen shot 2016-09-24 at 10 54 45 am

jpenninkhof commented 7 years ago

Hey @engswee, we're able to geocode your address a bit better now. Can you verify your pin again? If it's still not there or not accurate, please do feel free to re-open this ticket.

Also note that geocoding only takes place once every 24 hours due to rate limit contraints on the Google API that is taking care of the geocoding. Sorry for that.

engswee commented 7 years ago

Hi Jan

Unfortunately, the results are still the same. The pin is at Kuala Lipis, but it should be at Kuala Lumpur. As I'm not a collaborator, I don't think I can reopen this ticket.

pin

gregorwolf commented 7 years ago

I've maintained your address in my test system. Let's see if it is getting geocoded during the night job.

gregorwolf commented 7 years ago

Hi @engswee it seems that Google expects the State to be provided as "Wilayah Persekutuan Kuala Lumpur". I've updated your address information in lemonaid. Tomorrow the address should be correct. Best regards Gregor

engswee commented 7 years ago

Hi @gregorwolf

This is spot on! The pin on the map is now correct after the State field has been updated. Didn't know Google needed it to be that exact!

Thanks!